Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ads): marketplace settings wizard #2628

Merged
merged 6 commits into from
Sep 20, 2023
Merged

feat(ads): marketplace settings wizard #2628

merged 6 commits into from
Sep 20, 2023

Conversation

miguelpeixe
Copy link
Member

@miguelpeixe miguelpeixe commented Sep 4, 2023 •
edited
Loading

All Submissions:

Changes proposed in this Pull Request:

Details and instructions at Automattic/newspack-ads#718

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe mentioned this pull request Sep 5, 2023
Merged
@miguelpeixe miguelpeixe self-assigned this Sep 5, 2023
@miguelpeixe miguelpeixe marked this pull request as ready for review September 5, 2023 19:25
@miguelpeixe miguelpeixe requested a review from a team as a code owner September 5, 2023 19:25
@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Sep 5, 2023
@dkoo dkoo mentioned this pull request Sep 5, 2023
Merged
6 tasks
@miguelpeixe miguelpeixe requested a review from dkoo September 12, 2023 14:38
dkoo
dkoo approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@dkoo dkoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!

@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Sep 20, 2023
@miguelpeixe miguelpeixe merged commit b6a5b37 into epic/ads-marketplace Sep 20, 2023
3 checks passed
@miguelpeixe miguelpeixe deleted the feat/ads-marketplace-settings branch September 20, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkoo dkoo dkoo approved these changes

Assignees

@miguelpeixe miguelpeixe

Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguelpeixe @dkoo